TestInstfreqplot AssertionError (Debian bug 861091)

On some platforms other than x86_64, test_working in ltfatpy.tests.gabor.test_instfreqplot fails due to the difference of the results not being in the tolerance range.

See the Debian bug 861091 for details.

mentioned in commit 20df5dac

By Florent Jaillet on 2017-06-29T07:13:03 (imported from GitLab project)

I was able to replicate the problem on an arm64 computer.

The test fails because TestInstfreqplot.test_working() uses a too restrictive tolerance to consider that the result is close enough to the reference data computed with LTFAT in Octave on the amd64 architecture.

But I checked that the results are in fact quite close and that the failed test is probably not the sign of a real bug. The higher difference on the architectures arm64, mips64el and ppc64el is probably only due to the usual and normal double precision computation limitations.

So I simply modified the tolerance requirement in the commit 20df5dac, which solves the problem on the arm64 architecture.

I couldn't test for the mips64el and ppc64el architectures, but the new tolerance value might also solve the problem there. If it's not the case, I improved the error message to display the maximal error so we can better investigate the problem if still needed.

Note that the "mismatch" percentage given in the error message is only an indication of how many elements in the array are not falling into the tolerance limit for the comparison (but no information about how far they were was displayed until now).

I leave this issue open until we are able to check that the problem is solved for the mips64el and ppc64el architectures, which we should know thanks to the Debian build system logs with a new release.

By Florent Jaillet on 2017-06-29T07:59:48 (imported from GitLab project)

mentioned in commit c2f129fc

By Florent Jaillet on 2017-06-29T11:52:23 (imported from GitLab project)

Fixed with version 1.0.9 (master commit #5371fb42)

By Denis Arrivault on 2017-06-29T13:46:54 (imported from GitLab project)

closed

By Denis Arrivault on 2017-06-29T13:09:07 (imported from GitLab project)