From d9eb8ebb93ce393349704b215ba491507d9c8bc8 Mon Sep 17 00:00:00 2001
From: Franck Dary <franck.dary@lis-lab.fr>
Date: Tue, 19 Jan 2021 12:53:41 +0100
Subject: [PATCH] Improved error message for failed stof in NumericColumnModule

---
 torch_modules/src/NumericColumnModule.cpp | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/torch_modules/src/NumericColumnModule.cpp b/torch_modules/src/NumericColumnModule.cpp
index 21ea408..29138d5 100644
--- a/torch_modules/src/NumericColumnModule.cpp
+++ b/torch_modules/src/NumericColumnModule.cpp
@@ -80,8 +80,9 @@ void NumericColumnModuleImpl::addToContext(std::vector<std::vector<long>> & cont
       if (index >= 0)
       {
         auto value = config.getAsFeature(column, index).get();
-        try {res = std::stof(value);}
-        catch (std::exception &) {res = defaultValue;}
+        try {res = value == "_" ? defaultValue : std::stof(value);}
+        catch (std::exception & e)
+          {util::myThrow(fmt::format("{} for '{}'", e.what(), value));}
       }
 
       contextElement.emplace_back(0);
-- 
GitLab