diff --git a/reading_machine/src/Action.cpp b/reading_machine/src/Action.cpp index 2ef4baa1cde8316079c87070646db897a18dd190..a6acb5228b0fc018cf4d6489e1ea49d63898ecde 100644 --- a/reading_machine/src/Action.cpp +++ b/reading_machine/src/Action.cpp @@ -1061,7 +1061,7 @@ Action Action::writeScore(const std::string & colName, Config::Object object, in int lineIndex = config.getRelativeWordIndex(object, relativeIndex); float score = config.getChosenActionScore(); - if (score != std::numeric_limits<float>::min()) + if (-score != std::numeric_limits<float>::max()) return addHypothesis(colName, lineIndex, fmt::format("{}", score)).apply(config, a); else return addHypothesis(colName, lineIndex, config.getConst(colName, lineIndex, 0)).apply(config, a); diff --git a/trainer/src/MacaonTrain.cpp b/trainer/src/MacaonTrain.cpp index 923bbff97e1936c51a556f402d6449520454348a..f4504081a8cdb5426b5bf919252ad0e9757709c9 100644 --- a/trainer/src/MacaonTrain.cpp +++ b/trainer/src/MacaonTrain.cpp @@ -167,7 +167,8 @@ int MacaonTrain::main() Trainer trainer(machine, batchSize); Decoder decoder(machine); - float bestDevScore = computeDevScore ? std::numeric_limits<float>::min() : std::numeric_limits<float>::max(); + float bestDevScore = computeDevScore ? -std::numeric_limits<float>::max() : std::numeric_limits<float>::max(); + fmt::print("best = {}\n", bestDevScore); auto trainInfos = machinePath.parent_path() / "train.info"; diff --git a/trainer/src/Trainer.cpp b/trainer/src/Trainer.cpp index d78b98038987d120937448ac0b8eb9a9c1a2c3bf..bdd5b33515e23c8fa79bbb599666b7c3f10a73ee 100644 --- a/trainer/src/Trainer.cpp +++ b/trainer/src/Trainer.cpp @@ -82,7 +82,7 @@ void Trainer::extractExamples(SubConfig & config, bool debug, std::filesystem::p int nbClasses = machine.getTransitionSet(config.getState()).size(); - float bestScore = std::numeric_limits<float>::min(); + float bestScore = -std::numeric_limits<float>::max(); if (dynamicOracle and util::choiceWithProbability(1.0) and config.getState() != "tokenizer" and config.getState() != "segmenter") {