From 1afc1d777f4b0f81b45feb5d2c011dd6f0c0d26a Mon Sep 17 00:00:00 2001 From: Franck Dary <franck.dary@lis-lab.fr> Date: Thu, 28 May 2020 12:39:09 +0200 Subject: [PATCH] Fixed --devScore argument --- decoder/src/Decoder.cpp | 2 +- trainer/src/MacaonTrain.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/decoder/src/Decoder.cpp b/decoder/src/Decoder.cpp index 9ec2480..f0e4bfc 100644 --- a/decoder/src/Decoder.cpp +++ b/decoder/src/Decoder.cpp @@ -141,7 +141,7 @@ void Decoder::evaluate(const Config & config, std::filesystem::path modelPath, c config.print(predictedTSVFile); std::fclose(predictedTSVFile); - std::FILE * evalFromUD = popen(fmt::format("{} {} {} -v", "../scripts/conll18_ud_eval.py", goldTSV, predictedTSV).c_str(), "r"); + std::FILE * evalFromUD = popen(fmt::format("{} {} {}", "../scripts/conll18_ud_eval.py", goldTSV, predictedTSV).c_str(), "r"); char buffer[1024]; while (!std::feof(evalFromUD)) diff --git a/trainer/src/MacaonTrain.cpp b/trainer/src/MacaonTrain.cpp index 5de8971..85c1def 100644 --- a/trainer/src/MacaonTrain.cpp +++ b/trainer/src/MacaonTrain.cpp @@ -230,7 +230,7 @@ int MacaonTrain::main() std::vector<std::pair<float,std::string>> devScores; if (computeDevScore) { - auto devConfig = devGoldConfig; + BaseConfig devConfig(mcdFile, computeDevScore ? (devRawFile.empty() ? devTsvFile : "") : devTsvFile, devRawFile); decoder.decode(devConfig, 1, 0.0, debug, printAdvancement); decoder.evaluate(devConfig, modelPath, devTsvFile); devScores = decoder.getF1Scores(machine.getPredicted()); -- GitLab